03-16-2021 01:11 PM
03-16-2021 02:01 PM
DanishbluntAssembly Language? Sounds like the display manufacturer of the display didn't give the full details of how their display works. Even if ASUS do hire low level programmers, they would still need the time to research on the display.
After looking into the kernel and see how everything is built up. I can tell you why black crush hasn't been fixed yet and why it's rather difficult. Many have been wondering, well why hasn't ASUS fixed this issue by now despite being such a big problem. For why black crush is happening, I made a video about it which can easily be found on youtube and via google titled "Blackcrush explained" so I won't be explaining that, however there is a big big problem here, and that is the lack of an easy way to drive the display. You see the software developers working for asus are devs specialized at working on applications, they are specialized on working on software solutions only. This is also the reason why the developers try to fix the black crush with an overlay, which simply won't work.
So what is the requirement in order to fix the gamma on the display? Well there is the problem, in order to be able to fix the gammalevel of the display you will need to tell the display direcly how to behave. Normally when you work with a top level programming language you have functions you can use in order to tell the hardware what to do, an example like:
However due to the lack of such a feature, you'll have to do it in a much more complicated manner. Let's take an example from the nubia phone which has a gamma corrected screen:
mipi_dsi_dcs_write (dsi, 0xC7, gamma6,sizeof(gamma6));
Well great isn't it? What the fk is this supposed to mean?
Well from what I can tell this function writes direcly to a device, the arguments meaning:
- dsi -> The device it writes to, the object in this case being the display
- 0xC7 -> Being a DCS command
- Gamma6 being a buffer that contains a payload.
- and lastly the lenght of the payload
Even understanding this doesn't help much because while I do somewhat the code from the nubia solution I have no fking clue how I would implement this on the ASUS phone. You see in order to extract the gamma value they direcly red some values from adresses and defined them as gamma 1 - 10, however how they know, neither me nor the ASUS devs know, because this is more for people specialized in low level programming.
And before you ask why ASUS didn't hire a low level programmer then, well the answer is, it's hard to find one, we talk really hard.
I hope you now understand more as to why black crush hasn't been fixed yet. This also means, even with Android 11, black crush will still be an issue.
Why no blackcrush fix? Here is why!
03-16-2021 02:16 PM
ronald1985It's quite unusual for display manufacturers to give out any useful API's to control the panel. This is also why the pixel2XL and samsung S9 still have black crush to this date.
Assembly Language? Sounds like the display manufacturer of the display didn't give the full details of how their display works. Even if ASUS do hire low level programmers, they would still need the time to research on the display.
Probably the reason why this year is a Samsung display (don't know how true this is), so we will find out very soon. (Read your other post, ROG 5 could have black crush)
But anyhow, this is a good read.